Adjustments to support Coq 8.18.0 #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… point constructors
|
I like your version better since it gets rid of a dubious technique with the opaque lets. Coq added proper support for that use case with the new |
Alizter
approved these changes
Sep 18, 2023
|
Thanks, I'll merge. In general, I'm going to lean towards faster merging for straightforward changes, since it's getting harder to get two approvals. I'm always happy to make further changes after merging if anyone notices things that can be improved. |
|
@jdchristensen I think the 2 approvals requirement is a bit hopeful for the time being. I don't mind asking for 1 as long as we continue to review like we have been doing. |
|
Yeah, if we really only have 2 active contributors, asking for 2 approvals on each PR is a bit much. (-: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
Pushout_ind(and therefore various other things) to compute; loosen some universe variables; changeLet ... QedtoLocal Definition ... Qedto truly hide the contents (and make some proof terms much smaller); silence two warnings about minimization to Set.Each commit can be read independently.
Everything builds fine with Coq 8.17 as well.